Re: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the "goto" error recovery scheme.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I suggest to use the summary phrase “Use common error handling code
in pi433_init()” instead.


> pi433_init had "unregister_chrdev" called twice.
> Remove it using goto statements.

How do you think about to use the following change description?

   unregister_chrdev() was called in two if branches.
   Thus add jump targets so that a bit of exception handling can be better
   reused at the end of this function implementation.


…
v2->v3:
…
          a seperate patch.
…

Would you like to avoid a typo here?

Regards,
Markus





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux