Hi Umang, Am 30.03.24 um 17:04 schrieb Umang Jain:
This reverts commit d9c60badccc183eb971e0941bb86f9475d4b9551. It has been reported that stopping kthreads corrupts the VC04 firmware and creates issues at boot time. A fix-up version of this patch [2] was also attempted but it also doesn't
the usual approach (hash + subject) to reference a commit would be better, even the commit hasn't be applied yet to mainline.
properly fix the TODO (i.e. clean module unload) and similar errors were observed when stopping these khthreads on RaspberryPi 3. Hence, revert the entire patch for now since it is not very clear why stopping the kthreads breaks the firmware. [1]: https://lore.kernel.org/linux-staging/CAPY8ntBaz_RGr2sboQqbuUv+xZNfRct6-sckDLYPTig_HWyXEw@xxxxxxxxxxxxxx/t/#me90b9a9bc91599f18cd65ceb7eedd40e5fee0cdd
There is no reference to [1]. I assume this should be in the second sentence. Except of these nits, the patch looks good to me. Best regards
[2]: https://lore.kernel.org/linux-staging/171161507013.3072637.12125782507523919379@xxxxxxxxxxxxxxxxxxxxxxxx/T/#m1d3de7d2fa73b2447274858353bbd4a0c3a8ba14 Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> ---
