Quoting Umang Jain (2024-03-21 13:07:35) > Do not log any error for kzalloc() error path. kzalloc() already reports > such errors. > > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> Given I read lately how I don't think these can actually ever fail: - https://lwn.net/Articles/964793/ and - https://lwn.net/Articles/723317/ - https://lwn.net/Articles/627419 Removing these messages seems fine to me. Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index b3021739b170..ad506016fc93 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -690,7 +690,6 @@ int vchiq_initialise(struct vchiq_instance **instance_out) > > instance = kzalloc(sizeof(*instance), GFP_KERNEL); > if (!instance) { > - dev_err(state->dev, "core: %s: Cannot allocate vchiq instance\n", __func__); > ret = -ENOMEM; > goto failed; > } > @@ -956,10 +955,8 @@ vchiq_blocking_bulk_transfer(struct vchiq_instance *instance, unsigned int handl > } > } else { > waiter = kzalloc(sizeof(*waiter), GFP_KERNEL); > - if (!waiter) { > - dev_err(service->state->dev, "core: %s: - Out of memory\n", __func__); > + if (!waiter) > return -ENOMEM; > - } > } > > status = vchiq_bulk_transfer(instance, handle, data, NULL, size, > -- > 2.43.0 >
