Re: [PATCH 3/5] staging: vc04_services: Do not log error on kzalloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 15, 2024 at 04:26:57PM +0530, Umang Jain wrote:
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 3c3e6f3e48ce..1151cb4a84f9 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -690,7 +690,6 @@ int vchiq_initialise(struct vchiq_instance **instance_out)
>  
>  	instance = kzalloc(sizeof(*instance), GFP_KERNEL);
>  	if (!instance) {
> -		dev_err(state->dev, "core: %s: Cannot allocate vchiq instance\n", __func__);
>  		ret = -ENOMEM;
>  		goto failed;
>  	}
> @@ -957,7 +956,6 @@ vchiq_blocking_bulk_transfer(struct vchiq_instance *instance, unsigned int handl
>  	} else {
>  		waiter = kzalloc(sizeof(*waiter), GFP_KERNEL);
>  		if (!waiter) {
> -			dev_err(service->state->dev, "core: %s: - Out of memory\n", __func__);
>  			return -ENOMEM;
>  		}

You need to remove the curly braces now as well.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux