Hi Umang, Thank you for the patch. On Fri, Mar 15, 2024 at 04:26:55PM +0530, Umang Jain wrote: > vchiq_loud_error-* are unused hence, remove their declarations. I'd write "not implemented" instead of "unused". > This seem to be remnants of custom logging helpers which were > removed earlier. > > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > index c8527551b58c..5fbf173d9c56 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > @@ -470,12 +470,6 @@ vchiq_bulk_transfer(struct vchiq_instance *instance, unsigned int handle, void * > extern void > vchiq_dump_state(struct seq_file *f, struct vchiq_state *state); > > -extern void > -vchiq_loud_error_header(void); > - > -extern void > -vchiq_loud_error_footer(void); > - > extern void > request_poll(struct vchiq_state *state, struct vchiq_service *service, > int poll_type); -- Regards, Laurent Pinchart
