Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 13.03.24 um 17:08 schrieb Miguel Ojeda:
Hi Thomas,

Thanks for this!

Cc'ing Andy and Geert -- the new maintainer and reviewer.

Ah, sorry. They are not yet in my MAINTAINERS file.


Also, a couple quick notes below since I am here...

On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
Replace the use of struct backlight_properties.fb_blank with a
call to backlight_get_brightness(). The helper implement the same
logic as the driver's function.
It is not exactly the same logic since `backlight_is_blank` accounts
for `BL_CORE_SUSPENDED`.

As Sam already said, it doesn't seem to make different in practice. I'd mention it in the commit message and that's it. Ok?

Best regards
Thomas


-       int brightness = bl->props.brightness;
+       int brightness = backlight_get_brightness(bl);
This can be `const` now (or even removed and have the call embedded below).

Cheers,
Miguel

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux