Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Miguel.

On Wed, Mar 13, 2024 at 05:08:08PM +0100, Miguel Ojeda wrote:
> Hi Thomas,
> 
> Thanks for this!
> 
> Cc'ing Andy and Geert -- the new maintainer and reviewer.
> 
> Also, a couple quick notes below since I am here...
> 
> On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> >
> > Replace the use of struct backlight_properties.fb_blank with a
> > call to backlight_get_brightness(). The helper implement the same
> > logic as the driver's function.
> 
> It is not exactly the same logic since `backlight_is_blank` accounts
> for `BL_CORE_SUSPENDED`.

The driver does not set BL_CORE_SUSPENDRESUME so that part is a nop.

	Sam




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux