On Wed, Mar 13, 2024 at 09:18:08AM +0100, Julia Lawall wrote: > > > On Wed, 13 Mar 2024, Ayush Tiwari wrote: > > > Rename local variable tmpVal to pct_val in function process_link_qual > > to give intuitive meaning to variable and match the common kernel > > coding style. > > I don't think that the patch with the name avg_val was accepted, so this > patch has to replace tmpVal by pct_val, as you say in the subject line. > > Also, the comment says: > > /* <1> Showed on UI for user, in percentage. */ > > I still have the impression that the value calculated here is an average. > Total num is just incremented: > > if (sqd->total_num++ >= PHY_LINKQUALITY_SLID_WIN_MAX) > > while total_val is updated with a new value. Oh, yeah. My bad. I misunderstood the comment. The original value is in percent. prframe->u.hdr.attrib.signal_qual. It's set in query_rx_phy_status(). Sorry about that. regards, dan carpenter
