On Tue, Mar 12, 2024 at 04:46:07AM +0530, Umang Jain wrote:
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> index 3cad13f09e37..4b79fccaa95e 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> @@ -6,19 +6,13 @@
> #include <linux/module.h>
> #include <linux/mutex.h>
>
> -#define MAX_CALLBACKS 10
> -
> -static int g_connected;
> -static int g_num_deferred_callbacks;
> -static void (*g_deferred_callback[MAX_CALLBACKS])(void);
> -static int g_once_init;
> static DEFINE_MUTEX(g_connected_mutex);
>
> /* Function to initialize our lock */
> -static void connected_init(void)
> +static void connected_init(struct vchiq_connected *drv_connected)
> {
> - if (!g_once_init)
> - g_once_init = 1;
> + if (!drv_connected->once_init)
> + drv_connected->once_init = 1;
This is a nonsense function... once_init is never used. Could you
delete this function in a separate patch at the start?
> }
>
Otherwise, I think it looks okay. How are you testing this, btw?
regards,
dan carpenter
