On Tue, Mar 12, 2024 at 9:25 PM Alison Schofield <alison.schofield@xxxxxxxxx> wrote: Greetings Alison, Thanks for the review. I will work and resubmit the v4 as guided. Regards > > On Tue, Mar 12, 2024 at 06:11:53PM +0100, Felix N. Kimbu wrote: > > Hi Felix, > Thanks for sending this v3 as a new patch. Now, I'm going to ask > you to create a v4 to straighten out a bit more of the patch > format. > > The commit message below includes some revision history that only > belongs below the '---', Your commit message will be with this > patch when it is committed, and the changelog will fall away. > The changelog benefits reviewers today, and it also is always > retrievable in Lore for folks curious about the patches journey. > > So, I'll make some edits directly below indicating what I think > v4 should look like. > > Caveat 1: I didn't test the patch. I expect it applies, compiles, > and passes checkpatch. Double check that all on v4. > > Caveat 2: I don't know if GregKH is going to accept this trivial > patch. That's OK. By the time we get though v4 you will have > applied a bunch of patching practices that you can take forward > to your next patches. > > > Rename identifer 'foo' to 'rc' Suggested-by Alison Schofield in functions > > skb_p80211_to_ether() and skb_ether_to_p80211(). > > > > Replace above with: > Rename identifier 'foo' to 'rc' in skb_p80211_to_ether() and > skb_ether_to_p80211() to match the common kernel coding style. > > (Try to get the spell checker running with checkpatch to catch things > like the misspelled 'identifer' above.) > > > Delete from here: > > Fix indentation necessitated by above rename Suggested-by Dan Carpenter > > and Philipp Hortmann. > > > > This change adds intuitive meaning to the idenfier, adhering to best > > practices and coding style. > > > to here. > > > > > Signed-off-by: Felix N. Kimbu <felixkimbu1@xxxxxxxxx> > > --- > > (The names in parens is optional. Folks often do it to make > it easier for reviewers to find what they last commented, and > also it is a bit of a nod, appreciating your reviewers) > > Changes in v4: > - Remove changelog comments from commit log (AlisonS) > > Changes in v3: > - Create a proper new patch revision (AlisonS) > - Use 'rc' instead of 'decrypt_check' (AlisonS) > > Changes in v2: > - Fix wrong indentation introduced in v1 (DanC) > - Correct subject to include driver (PhilippH) > >
