On Mon, 11 Mar 2024, Philipp Hortmann wrote: > On 3/11/24 18:05, Julia Lawall wrote: > > > > > > On Mon, 11 Mar 2024, Felix N. Kimbu wrote: > > > > > Remove unnecessary parentheses around 'wlandev->msdstate != > > > WLAN_MSD_RUNNING' > > > in static int prism2_get_station(...) > > > > You don't need the name of the function in the subject line. That > > information doesn't help understand the patch. > > > > julia > > Hi Julia, > > I think we do not need the function name in the subject but we need something > to distinguish between the patches. The subject line needs to be a little > unique. Otherwise we will have 100 patches like "[PATCH] staging: cfg80211: > Remove parentheses" when we are unlucky. Any better proposal for a Subject > uniqueness is welcome. > > Function name for this purpose is OK for me. OK, no problem. thanks, julia > > Thanks for your support. > > Bye Philipp > > > > > > > > > > This change ensures adherence to coding style guidelines. > > > > > > Signed-off-by: Felix N. Kimbu <felixkimbu1@xxxxxxxxx> > > > --- > > > drivers/staging/wlan-ng/cfg80211.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/wlan-ng/cfg80211.c > > > b/drivers/staging/wlan-ng/cfg80211.c > > > index 471bb310176f..7451fd2bb580 100644 > > > --- a/drivers/staging/wlan-ng/cfg80211.c > > > +++ b/drivers/staging/wlan-ng/cfg80211.c > > > @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, > > > struct net_device *dev, > > > > > > memset(sinfo, 0, sizeof(*sinfo)); > > > > > > - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING)) > > > + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING) > > > return -EOPNOTSUPP; > > > > > > /* build request message */ > > > -- > > > 2.34.1 > > > > > > > > > > > > >
