The main issue with this patch is that it doesn't apply, but I have a
few other comments as well.
Why is Forest Bond not on the CC list? Please use get_maintainer.pl.
On Mon, Mar 11, 2024 at 06:07:47AM +0000, Dorine Tipo wrote:
> Remove RFbAL7230SelectChannelPostProcess as it is dead code.
>
This isn't enough information. At first I thought the function
declaration was commented out, but then i noticed that it was just the
weird curly braces stuff that was commented. So I thought maybe it
wasn't dead code. Then I have to do a grep and search through git log
to find why there isn't a RFbAL7230SelectChannelPostProcess() function.
I want that sort of information in the commit message.
"Commit dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
removed the RFbAL7230SelectChannelPostProcess() but accidentally forgot
to delete the declaration in the header file. Delete it." Since
Philipp wrote commit dd2837bdea0e, you should add him to the CC list.
> This commit removes the dead code to improve code cleanliness and reduce
> unnecessary complexity in the driver.
This paragraph is unnecessary, we all know why dead code is bad.
>
> staging: vt6655: Remove multiple blank lines
>
> Fix unintended blank line introduced after removing dead code
>
> The previous commit inadvertently introduced a blank line after removing
> dead code from the rf.h file in the staging/vt6655 directory. This commit
> removes the unintended blank line to maintain code consistency.
>
We aren't going to apply the previous commit... So the patch is not
going to apply and the commit message kind of doesn't make sense. I
have written a very short blog about how to send v2 patches.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
