On Wed, 6 Mar 2024, Dorine Tipo wrote: > Hello, > > This V2 series addresses the Avoid CamelCase checkpatch warning by renaming > the variables in sm750fb driver to use snake_case. > > Patch 1 renames variable sii164GetDeviceID to sii164_get_device_id. > > Patch 2 renames variable sii164ResetChip to sii164_reset_chip. > > Patch 3 renames variable sii164GetChipString to sii164_get_chip_string. > > Patch 4 renames variable sii164SetPower to sii164_set_power. > > Patch 5 renames variable sii164EnableHotPlugDetection to > sii164_enable_hot_plug_detection. > > Patch 6 renames variable sii164IsConnected to sii164_is_connected. > > Patch 7 renames variable sii164CheckInterrupt to sii164_check_interrupt. > > Patch 8 renames variable sii164ClearInterrupt to sii164_clear_interrupt. > > Updates since V1: > Incorporated feedback from <gregkh@xxxxxxxxxxxxxxxxxxx> to fix the > warnings in the patches and create a patch series for the same. > I have also compiled the entire kernel and it compiled successfully. > (I understand this is not sufficient and would be happy to run further > tests. Should I run kselftests on the module?) > > Updates since V2: > Incorporated feedback from <dan.carpenter@xxxxxxxxxx> and reverted the > sii164GetDeviceID since it breaks the build. Hello Dorine. Thank you for your efforts. However, I don't understand how you can just change a variable reference and not change the definition at the same time. So I wonder how any of the patches can compile. Are there some ifdefs that mean that the code is actually ignores? Do you get a .o file for the relevant file? If so, do you see any ifdefs in the code that might affect the code you changed? julia > > Dorine Tipo (8): > Staging: sm750fb: Rename sii164ResetChip > Staging: sm750fb: Rename variable sii164GetChipString > Staging: sm750fb: Rename variable sii164SetPower > Staging: sm750fb: Rename variable sii164EnableHotPlugDetection > Staging: sm750fb: Rename variable sii164IsConnected > Staging: sm750fb: Rename variable sii164CheckInterrupt > Staging: sm750fb: Rename Variable sii164ClearInterrupt > Revert "Staging: sm750fb: Rename variable sii164GetDeviceID" > > drivers/staging/sm750fb/ddk750_dvi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > -- > 2.25.1 > > >
