On Wed, Mar 06, 2024 at 05:44:51AM +0000, Dorine Tipo wrote:
> Rename variable sii164ResetChip to sii164_reset_chip to silence
> checkpatch warning Avoid CamelCase
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@xxxxxxxxx>
> ---
> V2: Added the patch to a series.
> Fixed errors within the patch.
> Compiled the kernel
>
> V3: Reverted a commit in the same patch series
You we can't revert a patch which was never applied. Please wait at
least a day between resends.
>
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 3fb14eff2de1..6dee95e60a6e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> .get_vendor_id = sii164_get_vendor_id,
> .get_device_id = sii164_get_device_id,
> #ifdef SII164_FULL_FUNCTIONS
> - .reset_chip = sii164ResetChip,
> + .reset_chip = sii164_reset_chip,
>From looking at this patch you would assume that it would break the
build but actually it seems that SII164_FULL_FUNCTIONS is never defined.
The advice is always to just delete dead code.
We can't apply any of these patches...
regards,
dan carpenter
