Re: [PATCH] Staging: sm750fb: Rename variable sii164EnableHotPlugDetection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 05, 2024 at 10:45:18PM +0000, Dorine Tipo wrote:
> Rename variable sii164EnableHotPlugDetection to
> sii164_enable_hot_plug_detection to silence checkpatch warning Avoid
> CamelCase
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@xxxxxxxxx>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index c12df1f9fb00..1ce44c50617a 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
>  		.reset_chip = sii164_reset_chip,
>  		.get_chip_string = sii164_get_chip_string,
>  		.set_power = sii164_set_power,
> -		.enable_hot_plug_detection = sii164EnableHotPlugDetection,
> +		.enable_hot_plug_detection = sii164_enable_hot_plug_detection,
>  		.is_connected = sii164IsConnected,
>  		.check_interrupt = sii164CheckInterrupt,
>  		.clear_interrupt = sii164ClearInterrupt,
> --
> 2.25.1
> 
> 

Hi,

You sent 5 patches, all look to be broken and not tested.  Please fix
them up and send them as a patch series.

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux