Re: [PATCH] Staging: rtl8192e: Sparse warning regarding variable declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/28/24 08:25, Ariel Silver wrote:
Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?"
As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.


Hi Ariel,

please use checkpatch to check your patch:

File Nr: 0 Patch: ../../../Downloads/20240228-[PATCH] Staging_ rtl8192e_ Sparse warning regarding variable declaration-14757.txt WARNING: A patch subject line should describe the change not the tool that found it
#1:
Subject: [PATCH] Staging: rtl8192e: Sparse warning regarding variable declaration

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?"

total: 0 errors, 2 warnings, 0 checks, 8 lines checked

Please make a v2 with change description under the "---"

Thanks for your support.

Bye Philipp




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux