Re: [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Shahar Avidar <ikobh7@xxxxxxxxx>
Subject: Re: [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 26 Feb 2024 16:46:14 +0200
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, luca.ceresoli@xxxxxxxxxxx, benjamin.tissoires@xxxxxxxxxx, elder@xxxxxxxxxx, robh@xxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20240225173341.1278918-4-ikobh7@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20240225173341.1278918-1-ikobh7@gmail.com> <20240225173341.1278918-4-ikobh7@gmail.com>

On Sun, Feb 25, 2024 at 07:33:40PM +0200, Shahar Avidar wrote:
> FIFO_SIZE is being used in both rf69.c & pi433_if.c source files
> It is also already defined in rf69.h header file

You can done this before patch 1, so the code will be cleaner already.

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH 0/4] Fix defines in rf69.h
  - From: Shahar Avidar
- [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define
  - From: Shahar Avidar

Prev by Date: Re: [PATCH 7/8] Staging: rtl8192e: Rename function rtllib_FlushRxTsPendingPkts()
Next by Date: [PATCH v2 01/20] Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq()
Previous by thread: [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define
Next by thread: [PATCH 1/4] staging: pi433: Remove a duplicated F_OSC define
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux