On Sun, Feb 25, 2024 at 2:26 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > Did you test build this? Hello Greg, Yes. No new warning/error was encountered on building the kernel. > > #define gb_loopback_attr(field, type) \ > > static ssize_t field##_show(struct device *dev, \ > > Why did you only change one if you thought this was a valid change? 1. As per my C background, I think no other macros in the above source code file need to be enclosed in a do - while loop. 2. I am writing the patch because of the Eudyptula Challenge, and I have to fix "one coding style problem" in any of the files in drivers/staging/. The above one was one of them. Regards, Dileep
