Ok.. thanks for the explanation. Did not want to ask back stupidly what the script was actually complaining about without providing a suggestion on what I understood what it was asking for. I will submit a version 3 patch for the braces and a separate blank line patch with both good cover letters. Best regards, Moritz On Mon, Feb 19, 2024 at 9:17 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Mon, Feb 19, 2024 at 10:38:30AM +0300, Dan Carpenter wrote: > > On Sat, Feb 17, 2024 at 10:12:38PM +0100, Moritz C. Weber wrote: > > > Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot > > > > > > Moritz C. Weber (8): > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix blank line style check > > This blank line patch would be still separate of course. > > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > > Staging: vc04_services: bcm2835-camera: fix brace code style check > > regards, > dan carpenter >