On Sat, Feb 17, 2024 at 1:25 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > The atomisp driver's Android heritage makes it weird in that > even though it uses MC + subdev-s it is designed to primarily > be controlled through its /dev/video# node. > > It implements s_input on /dev/video# to select which sensor to use, > while ignoring setup_link calls to enable a link to another sensor. > > Add support for selecting the active sensor the MC way by adding > setup_link support. ->link_setup() > The implementation is a bit convoluted due to the atomisp driver's > heritage. ... > #include "atomisp_common.h" > #include "atomisp_compat.h" > #include "atomisp_fops.h" > +#include "atomisp_ioctl.h" > #include "atomisp_internal.h" Hmm... Perhaps keep it ordered? ... > + mutex_lock(&isp->mutex); Side note: Are you planning to use cleanup.h at some point? > + ret = atomisp_pipe_check(&asd->video_out, true); > + if (ret == 0) > + asd->input_curr = i; > + mutex_unlock(&isp->mutex); > + > + return ret; -- With Best Regards, Andy Shevchenko
