On Thu, Jan 25, 2024 at 09:29:37PM +0100, Uwe Kleine-König wrote: > On Thu, Jan 25, 2024 at 11:32:47AM -0800, Florian Fainelli wrote: > > On 1/25/24 04:08, Uwe Kleine-König wrote: > > > Currently a pwm_chip stores in its struct device *dev member a pointer > > > to the parent device. Preparing a change that embeds a full struct > > > device in struct pwm_chip, this accessor macro should be used in all > > > drivers directly accessing chip->dev now. This way struct pwm_chip and > > > this macro can be changed without having to touch all drivers in the > > > same change set. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > Nit: this is not a macro but an inline function. > > Oh right, it used to be a macro, but I changed that. I made the commit > log read: > > pwm: Provide an inline function to get the parent device of a given chip > > Currently a pwm_chip stores in its struct device *dev member a pointer > to the parent device. Preparing a change that embeds a full struct > device in struct pwm_chip, this accessor function should be used in all > drivers directly accessing chip->dev now. This way struct pwm_chip and > this new function can be changed without having to touch all drivers in > the same change set. While looking into further feedback, I noticed I did the same mistake in all the patches that convert the drivers to use this function. I did git filter-branch --msg-filter 'sed "s/Make use of pwmchip_parent() macro/Make use of pwmchip_parent() accessor/; s/commit as struct pwm_chip::dev, use the macro/commit as struct pwm_chip::dev, use the accessor/; s/provided for exactly this purpose./function provided for exactly this purpose./"' linus/master.. on my branch to make the typical commit log read: pwm: atmel: Make use of pwmchip_parent() accessor struct pwm_chip::dev is about to change. To not have to touch this driver in the same commit as struct pwm_chip::dev, use the accessor function provided for exactly this purpose. I wont resend the whole series if this is the only change to it. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
