Re: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in while loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 23, 2024 at 12:28:44PM +1300, Hoorad Farrokh wrote:
> Hello,
> Thanks for your comment.
> 
> > 
> > This function doesn't do anything...  The name says "free_all" but it
> > doesn't free anything.  I would prefer to fix this warning by adding
> > a comment:
> >
> 
> I didn't fully understand this part of your comment. Do you mean I should add a comment
> to the while loop + my changes and submit it agian? or 
> do you mean I should find a way to free things in the while loop? then submit again?
> 

Either one.

It's weird to note down the bugs in the source, but if we don't know how
to fix it, then perhaps that's the best we can do...

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux