Hi, Dan Thanks for your comment. > On Thu, Jan 11, 2024 at 12:41:15AM -0800, Changhuang Liang wrote: > > Register ISP 3A "capture_scd" video device to receive statistics > > collection data. > > > > Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> > > --- [...] > > @@ -150,6 +151,13 @@ static int stfcamss_register_devs(struct stfcamss > > *stfcamss) > > > > cap_yuv->video.source_subdev = &isp_dev->subdev; > > > > + ret = media_create_pad_link(&isp_dev->subdev.entity, > STF_ISP_PAD_SRC_SCD, > > + &cap_scd->video.vdev.entity, 0, 0); > > + if (ret) > > + goto err_cap_unregister; > > + > > Don't we need to do something like > > media_entity_remove_links(&cap_yuv->video.vdev.entity); > > as part of the cleanup? Also where do we clean up this new call to > media_create_pad_link() in the unregister process? > Yes, I will call it in next version. Original code is missing the cleanup process, add I will add it too. > > + cap_scd->video.source_subdev = &isp_dev->subdev; > > + > > return ret; > > > > err_cap_unregister: > > regards, > dan carpenter regards, Changhuang
