On Tue, Jan 09, 2024 at 11:30:17PM -0800, Randy Dunlap wrote: > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c > > index 36183f2a64c1..688c870d89bc 100644 > > --- a/drivers/staging/vt6655/card.c > > +++ b/drivers/staging/vt6655/card.c > > @@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask) > > * Return Value: none > > */ > > static void calculate_ofdmr_parameter(unsigned char rate, > > - u8 bb_type, > > - unsigned char *tx_rate, > > - unsigned char *rsv_time) > > + u8 bb_type, > > + unsigned char *tx_rate, > > + unsigned char *rsv_time) > > { > > switch (rate) { > > case RATE_6M: > > Is there any chance that checkpatch is wrong about this warning? > > I much prefer the alignment as it was before this patch: following lines > are aligned with the first parameter after the '('. > It just looks weird in the diff because of the + character at the front and how the tabs work out. It looks ok in the code. regards, dan carpenter