Gary Rookard <garyrookard@xxxxxxxxxxxx> writes: > Gary Rookard <garyrookard@xxxxxxxxxxxx> writes: > >> [[PGP Signed Part:Undecided]] >> >> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: >> >>> On Sun, Jan 07, 2024 at 10:22:29PM -0500, Gary Rookard wrote: >>>> Coding style issue, checkpatch avoid CamelCase, >>>> rename it. is40MHz -> is_40mhz >>>> >>>> Signed-off-by: Gary Rookard <garyrookard@xxxxxxxxxxxx> >>>> --- >>>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++-------- >>>> 1 file changed, 8 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c >>>> index 6d0912f90198..1b1cb9514028 100644 >>>> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c >>>> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c >>>> @@ -87,36 +87,36 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate) >>>> { >>>> struct rt_hi_throughput *ht_info = ieee->ht_info; >>>> >>>> - u8 is40MHz = (ht_info->cur_bw_40mhz) ? 1 : 0; >>>> + u8 is_40mhz = (ht_info->cur_bw_40mhz) ? 1 : 0; >>> >>> This should be is_40MHz. It's metric. M means Mega. m means milli. >>> >>> regards, >>> dan carpenter >> -- >> Okay, stupid me didin't give it to much thought that way, >> ...wow there's more that way then just mine >> Good catch! >> Regards, >> Gary -- There's only mine that I can find, I'll fix them up and resubmit them. Thanks for your insight. Regards, Gary -- Sent with my mu4e on Void GNU/Linux.
Attachment:
signature.asc
Description: PGP signature