On Fri, Dec 22, 2023 at 09:47:35AM +0100, Nam Cao wrote: > On Thu, 21 Dec 2023 20:22:48 +0000 Ryan England <rcengland@xxxxxxxxx> wrote: > > > Adhere to Linux kernel coding style. > > > > Reported by checkpatch: > > > > CHECK: Alignment should match open parenthesis > > > > Signed-off-by: Ryan England <rcengland@xxxxxxxxx> > > --- > > Made corrections give the 100 line limit. Resending v2 as no change was > > made other than including this comment below ---. Thank you for the > > correction. Here's to learning with every submission. > > > > drivers/staging/rtl8712/os_intfs.c | 3 +- > > drivers/staging/rtl8712/rtl8712_efuse.c | 9 +- > > drivers/staging/rtl8712/rtl8712_recv.c | 3 +- > > drivers/staging/rtl8712/rtl8712_xmit.c | 60 +++--- > > drivers/staging/rtl8712/rtl871x_cmd.c | 159 +++++--------- > > drivers/staging/rtl8712/rtl871x_cmd.h | 37 ++-- > > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 203 +++++++----------- > > 7 files changed, 173 insertions(+), 301 deletions(-) > > > > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c > > index b18e6d9c832b..7554613fe7e1 100644 > > --- a/drivers/staging/rtl8712/os_intfs.c > > +++ b/drivers/staging/rtl8712/os_intfs.c > > @@ -221,8 +221,7 @@ struct net_device *r8712_init_netdev(void) > > > > static u32 start_drv_threads(struct _adapter *padapter) > > { > > - padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", > > - padapter->pnetdev->name); > > + padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name); > > Your description claims to fix "CHECK: Alignment should match open > parenthesis", but this one is already aligned, isn't it? No. It was not aligned. There was a space character missing. regards, dan carpenter