On Sun, Dec 31, 2023 at 12:31 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > ATM the atomisp firmware is not available in linux-firmware, > so most users will not have it installed. > > Move pcim_enable_device() and pcim_iomap_regions() down in > atomisp_pci_probe() so that they are never called when the firmware > is not there. > > This is a preparation patch for making the atomisp driver handle > missing firmware better. ... > -atomisp_dev_alloc_fail: > - pcim_iounmap_regions(pdev, BIT(ATOM_ISP_PCI_BAR)); > - > -ioremap_fail: > return err; Before this patch, can you drop these two labels as one is not doing anything useful and the other diminishes the idea behind "m" (for managed)? -- With Best Regards, Andy Shevchenko
