On 12/8/23 22:56, Gary Rookard wrote:
Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> writes:
On 12/8/23 02:55, Gary Rookard wrote:
Hi,
This patch series renames 5 different variables with the checkpatch
coding style issue, Avoid CamelCase.
Patch 1/5) renamed variable bCurShortGI40MHz
Patch 2/5) renamed variable bcurShortGI20MHz
Patch 3/5) renamed variable CCKOFDMRate
Patch 4/5) renamed variable HTIOTActIsCCDFsync
Patch 5/5) renamed variable IOTPeer
Signed-off-by: Gary Rookard <garyrookard@xxxxxxxxxxxx>
Gary Rookard (5):
staging: rtl8192e: renamed variable bCurShortGI40MHz
staging: rtl8192e: renamed variable bCurShortGI20MHz
staging: rtl8192e: renamed variable CCKOFDMRate
staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
staging: rtl8192e: renamed variable IOTPeer
.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
5 files changed, 47 insertions(+), 47 deletions(-)
Please use present-tense as outlined here:
https://kernelnewbies.org/PatchPhilosophy
So rename instead of renamed
Please use a more unique Subject for your coverletter.
It often cannot cover everything. But more unique is better.
Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
Okay, "rename" it be, instead of me thinking in the past simple tense,
of "renamed".
As for the coverletter(s)...repetition a big problem.
There's not much in the way of uniqueness that can be added...regretfully
Tagging the Subject line with a numeric value is possible and
should deviate the coverletter(s) enough so they don't "appear the same".
e.g. staging: rtl8192e: this patch series (1) blah blah blah...
e.g. staging: rtl8192e: this patch series (2) blah blah blah...
e.g. staging: rtl8192e: this patch series (3) " " "
Regards,
Gary
Hi Gary
Here is a proposal:
[PATCH 0/5] staging: rtl8192e: Rename variable bCurShortGI40MHz and further
That will give a pretty good recognizable name.
Thanks for your support.
Bye Philipp
