This series also removes the vchiq_log_* macro and makes use of dev_*() logging helpers directly. Patch 1/4 removes vchiq_log_error() macro Patch 2/4 removes vchiq_log_warning() macro Patch 3/4 removes vchiq_log_trace() macro Patch 4/4 removes vchiq_log_debug() macro This completes the following TODO item: ``` * Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. ``` Changes in v3: - vchiq_log_error() will log to dev_err - vchiq_log_warn() will log to dev_warn - vchiq_log_trace() will log to dev_dbg Changes in v2: - Separate out one fixup patch from v1 (Patch 1/9)and send separately - Drop usage of log_type() and log_category() helpers. Directly use dev_dbg() as suggested by Greg KH. - Drop __func__ annotation from all logs. Dynamic debug has 'f' decorator flag which can be used instead of manual __func__ - Reword commit messages. Umang Jain (4): staging: vc04_services: Drop vchiq_log_error() in favour of dev_err staging: vc04_services: Drop vchiq_log_warning() in favour of dev_warn staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg drivers/staging/vc04_services/interface/TODO | 5 - .../interface/vchiq_arm/vchiq_arm.c | 178 ++++---- .../interface/vchiq_arm/vchiq_connected.c | 6 +- .../interface/vchiq_arm/vchiq_core.c | 403 +++++++++--------- .../interface/vchiq_arm/vchiq_core.h | 38 -- .../interface/vchiq_arm/vchiq_dev.c | 92 ++-- 6 files changed, 314 insertions(+), 408 deletions(-) -- 2.41.0
