On 04/12/2023 14:22, Benjamin Gaignard wrote: > This driver uses min_buffers_needed which vb2 uses to ensure > start_streaming is called when at least 'min_buffers_needed' > buffers are queued. However, this driver doesn't need this, > it can stream fine without any buffers queued. > Just drop this unnecessary restriction. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx> > CC: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> > --- > drivers/media/platform/ti/am437x/am437x-vpfe.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/ti/am437x/am437x-vpfe.c b/drivers/media/platform/ti/am437x/am437x-vpfe.c > index f18acf9286a2..228920450e7a 100644 > --- a/drivers/media/platform/ti/am437x/am437x-vpfe.c > +++ b/drivers/media/platform/ti/am437x/am437x-vpfe.c > @@ -2234,7 +2234,6 @@ static int vpfe_probe_complete(struct vpfe_device *vpfe) > q->buf_struct_size = sizeof(struct vpfe_cap_buffer); > q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > q->lock = &vpfe->lock; > - q->min_buffers_needed = 1; > q->dev = vpfe->pdev; > > err = vb2_queue_init(q); This driver needs one buffer as well, so drop this patch. Regards, Hans
