On Wed, Nov 29, 2023 at 01:50:05AM +0530, Umang Jain wrote: > %lx is used to print the unmodified pointer address for debugging. > %p will print the hashed pointer address to avoid leaking information > about kernel memory layout to userspace. But when `no_hash_pointers` > is passed as kernel parameter, unmodified pointer address will be > printed. > > Hence, drop %lx in favour of %p. For debugging purposes, one can > easily depend on `no_hash_pointers`. > > This also solves the following smatch warnings: > service_callback() warn: argument 7 to %lx specifier is cast from pointer > service_callback() warn: argument 11 to %lx specifier is cast from pointer > service_callback() warn: argument 12 to %lx specifier is cast from pointer > service_callback() warn: argument 13 to %lx specifier is cast from pointer > vchiq_release() warn: argument 7 to %lx specifier is cast from pointer > > Changes in v2: > - Built/Rebased on top of: > [PATCH v2 0/5] staging: vc04_services: Drop custom logging > > Umang Jain (2): > staging: vc04_services: Use %p to log pointer address > staging: vc04_services: Use %p to log pointer address You have 2 different patches that do different things, yet have the identical subject lines. That needs to be fixed up before I can take them. thanks, greg k-h
