Re: [PATCH 00/15] Staging: rtl8192e: Rename CamelCase vars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/23 06:42, Tree Davies wrote:
This Series renames 15 variables to fix checkpatch warnings.

Thank you in advance to reviewers
~Tree

Tree Davies (15):
   Staging: rtl8192e: Rename variable pTxTs
   Staging: rtl8192e: Rename variable BAReq
   Staging: rtl8192e: Rename variable Delba
   Staging: rtl8192e: Rename variable TSpec
   Staging: rtl8192e: Rename variable TxAdmittedBARecord
   Staging: rtl8192e: Rename variable TxPendingBARecord
   Staging: rtl8192e: Rename variable pDialogToken
   Staging: rtl8192e: Rename variable pTsCommonInfo
   Staging: rtl8192e: Rename variable TxCurSeq
   Staging: rtl8192e: Rename variable TsAddBaTimer
   Staging: rtl8192e: Rename variable DelbaParamSet
   Staging: rtl8192e: Rename variable pBaParamSet
   Staging: rtl8192e: Rename variable pBaTimeoutVal
   Staging: rtl8192e: Rename variable pAdmittedBA
   Staging: rtl8192e: Rename variable TsCommonInfo

  drivers/staging/rtl8192e/rtl819x_BAProc.c | 178 +++++++++++-----------
  drivers/staging/rtl8192e/rtl819x_TS.h     |  12 +-
  drivers/staging/rtl8192e/rtl819x_TSProc.c |  56 +++----
  drivers/staging/rtl8192e/rtllib.h         |   2 +-
  drivers/staging/rtl8192e/rtllib_tx.c      |  22 +--
  5 files changed, 135 insertions(+), 135 deletions(-)


Hi Tree,

thanks for your patches, those work on hardware well.

I am about to delete the block acknowledgment (ba) from the driver. Reason is that ba is not properly working. The AP seems to try around before it gives up. This is slowing down the connection build up.

My issue is that I need to remove the following parts:

Function rtllib_process_action() that reacts when the AP sends packets with ba.

The following three timers are also part of this functionality
timer_setup(&pTxTS->ts_add_ba_timer, TsAddBaProcess, 0);
timer_setup(&pTxTS->tx_pending_ba_record.timer, rtllib_ba_setup_timeout, 0);
timer_setup(&pTxTS->tx_admitted_ba_record.timer, rtllib_tx_ba_inact_timeout, 0);

And I cannot really remove the ones without the others. So some kind of encirclement is happening.

Just wanted to inform you about what I plan to do.

Have a good day.

Bye Philipp














[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux