On Mon, Nov 13, 2023 at 06:56:06PM +0100, Stefan Wahren wrote: > Hi Umang, > > Am 09.11.23 um 22:02 schrieb Umang Jain: > > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > > > Add Broadcom VideoCore Shared Memory support. > > > > This new driver allows contiguous memory blocks to be imported > > into the VideoCore VPU memory map, and manages the lifetime of > > those objects, only releasing the source dmabuf once the VPU has > > confirmed it has finished with it. > > > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> > > --- > > drivers/staging/vc04_services/Kconfig | 2 + > > drivers/staging/vc04_services/Makefile | 2 +- > > .../staging/vc04_services/vc-sm-cma/Kconfig | 10 + > > .../staging/vc04_services/vc-sm-cma/Makefile | 4 + > > .../staging/vc04_services/vc-sm-cma/vc_sm.c | 817 ++++++++++++++++++ > > .../staging/vc04_services/vc-sm-cma/vc_sm.h | 54 ++ > > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 507 +++++++++++ > > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.h | 63 ++ > > .../vc04_services/vc-sm-cma/vc_sm_defs.h | 187 ++++ > > .../vc04_services/vc-sm-cma/vc_sm_knl.h | 28 + > > 10 files changed, 1673 insertions(+), 1 deletion(-) > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Kconfig > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Makefile > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_defs.h > > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_knl.h [snip] > > diff --git a/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c b/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > new file mode 100644 > > index 000000000000..5bbdb3a8468b > > --- /dev/null > > +++ b/drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > > @@ -0,0 +1,817 @@ [snip] > > +/* ---- Private Variables ----------------------------------------------- */ > > + > > +static struct sm_state_t *sm_state; > > +static int sm_inited; > > In case the driver cannot be loaded again, a comment about this should > be here. Better, could we remove global variables ? [snip] -- Regards, Laurent Pinchart
