On Sun, Nov 12, 2023 at 07:57:10PM +0100, Wiktor Grzywacz wrote: > There is some old commented out code, that triggers > a checkpatch.pl no spaces before tabs warning. > > Signed-off-by: Wiktor Grzywacz <wiktor.grzywacz@xxxxxxxxx> > --- > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > index 2028791988e7..eb4e4f44d4cb 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > @@ -46,7 +46,6 @@ static void Init_ODM_ComInfo_8723b(struct adapter *Adapter) > ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_CUT_VER, cut_ver); > > ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_PATCH_ID, pHalData->CustomerID); > - /* ODM_CMNINFO_BINHCT_TEST only for MP Team */ > ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_BWIFI_TEST, Adapter->registrypriv.wifi_spec); Deleting that commit seems odd, why did you do that? why not just fix this properly? > > pdmpriv->InitODMFlag = ODM_RF_CALIBRATION|ODM_RF_TX_PWR_TRACK; > @@ -83,8 +82,6 @@ static void Update_ODM_ComInfo_8723b(struct adapter *Adapter) > /* */ > /* Pointer reference */ > /* */ > - /* ODM_CMNINFO_MAC_PHY_MODE pHalData->MacPhyMode92D */ > - /* ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_MAC_PHY_MODE,&(pDM_Odm->u8_temp)); */ Why delete one comment and then one line of commented out code? thanks, greg k-h
