Hi kenechukwu, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/kenechukwu-maduechesi/staging-rts5208-Replace-delay-function/20231018-090457 base: staging/staging-testing patch link: https://lore.kernel.org/r/20231018004300.GA3189%40ubuntu patch subject: [PATCH] staging: rts5208: Replace delay function. config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20231106/202311060455.MQsyG6kq-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/202311060455.MQsyG6kq-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202311060455.MQsyG6kq-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/staging/rts5208/sd.c:868:19: error: too few arguments to function call, expected 2, have 1 usleep_range(50); ~~~~~~~~~~~~ ^ include/linux/delay.h:66:20: note: 'usleep_range' declared here static inline void usleep_range(unsigned long min, unsigned long max) ^ drivers/staging/rts5208/sd.c:880:19: error: too few arguments to function call, expected 2, have 1 usleep_range(50); ~~~~~~~~~~~~ ^ include/linux/delay.h:66:20: note: 'usleep_range' declared here static inline void usleep_range(unsigned long min, unsigned long max) ^ drivers/staging/rts5208/sd.c:887:19: error: too few arguments to function call, expected 2, have 1 usleep_range(100); ~~~~~~~~~~~~ ^ include/linux/delay.h:66:20: note: 'usleep_range' declared here static inline void usleep_range(unsigned long min, unsigned long max) ^ drivers/staging/rts5208/sd.c:921:18: error: too few arguments to function call, expected 2, have 1 usleep_range(50); ~~~~~~~~~~~~ ^ include/linux/delay.h:66:20: note: 'usleep_range' declared here static inline void usleep_range(unsigned long min, unsigned long max) ^ drivers/staging/rts5208/sd.c:1419:19: error: too few arguments to function call, expected 2, have 1 usleep_range(100); ~~~~~~~~~~~~ ^ include/linux/delay.h:66:20: note: 'usleep_range' declared here static inline void usleep_range(unsigned long min, unsigned long max) ^ 5 errors generated. vim +868 drivers/staging/rts5208/sd.c 814 815 static int sd_change_phase(struct rtsx_chip *chip, u8 sample_point, u8 tune_dir) 816 { 817 struct sd_info *sd_card = &chip->sd_card; 818 u16 SD_VP_CTL, SD_DCMPS_CTL; 819 u8 val; 820 int retval; 821 bool ddr_rx = false; 822 823 dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n", 824 __func__, sample_point, tune_dir); 825 826 if (tune_dir == TUNE_RX) { 827 SD_VP_CTL = SD_VPRX_CTL; 828 SD_DCMPS_CTL = SD_DCMPS_RX_CTL; 829 if (CHK_SD_DDR50(sd_card)) 830 ddr_rx = true; 831 } else { 832 SD_VP_CTL = SD_VPTX_CTL; 833 SD_DCMPS_CTL = SD_DCMPS_TX_CTL; 834 } 835 836 if (chip->asic_code) { 837 retval = rtsx_write_register(chip, CLK_CTL, CHANGE_CLK, 838 CHANGE_CLK); 839 if (retval) 840 return retval; 841 retval = rtsx_write_register(chip, SD_VP_CTL, 0x1F, 842 sample_point); 843 if (retval) 844 return retval; 845 retval = rtsx_write_register(chip, SD_VPCLK0_CTL, 846 PHASE_NOT_RESET, 0); 847 if (retval) 848 return retval; 849 retval = rtsx_write_register(chip, SD_VPCLK0_CTL, 850 PHASE_NOT_RESET, PHASE_NOT_RESET); 851 if (retval) 852 return retval; 853 retval = rtsx_write_register(chip, CLK_CTL, CHANGE_CLK, 0); 854 if (retval) 855 return retval; 856 } else { 857 rtsx_read_register(chip, SD_VP_CTL, &val); 858 dev_dbg(rtsx_dev(chip), "SD_VP_CTL: 0x%x\n", val); 859 rtsx_read_register(chip, SD_DCMPS_CTL, &val); 860 dev_dbg(rtsx_dev(chip), "SD_DCMPS_CTL: 0x%x\n", val); 861 862 if (ddr_rx) { 863 retval = rtsx_write_register(chip, SD_VP_CTL, 864 PHASE_CHANGE, 865 PHASE_CHANGE); 866 if (retval) 867 return retval; > 868 usleep_range(50); 869 retval = rtsx_write_register(chip, SD_VP_CTL, 0xFF, 870 PHASE_CHANGE | 871 PHASE_NOT_RESET | 872 sample_point); 873 if (retval) 874 return retval; 875 } else { 876 retval = rtsx_write_register(chip, CLK_CTL, 877 CHANGE_CLK, CHANGE_CLK); 878 if (retval) 879 return retval; 880 usleep_range(50); 881 retval = rtsx_write_register(chip, SD_VP_CTL, 0xFF, 882 PHASE_NOT_RESET | 883 sample_point); 884 if (retval) 885 return retval; 886 } 887 usleep_range(100); 888 889 rtsx_init_cmd(chip); 890 rtsx_add_cmd(chip, WRITE_REG_CMD, SD_DCMPS_CTL, DCMPS_CHANGE, 891 DCMPS_CHANGE); 892 rtsx_add_cmd(chip, CHECK_REG_CMD, SD_DCMPS_CTL, 893 DCMPS_CHANGE_DONE, DCMPS_CHANGE_DONE); 894 retval = rtsx_send_cmd(chip, SD_CARD, 100); 895 if (retval != STATUS_SUCCESS) 896 goto fail; 897 898 val = *rtsx_get_cmd_data(chip); 899 if (val & DCMPS_ERROR) 900 goto fail; 901 902 if ((val & DCMPS_CURRENT_PHASE) != sample_point) 903 goto fail; 904 905 retval = rtsx_write_register(chip, SD_DCMPS_CTL, 906 DCMPS_CHANGE, 0); 907 if (retval) 908 return retval; 909 if (ddr_rx) { 910 retval = rtsx_write_register(chip, SD_VP_CTL, 911 PHASE_CHANGE, 0); 912 if (retval) 913 return retval; 914 } else { 915 retval = rtsx_write_register(chip, CLK_CTL, 916 CHANGE_CLK, 0); 917 if (retval) 918 return retval; 919 } 920 921 usleep_range(50); 922 } 923 924 retval = rtsx_write_register(chip, SD_CFG1, SD_ASYNC_FIFO_NOT_RST, 0); 925 if (retval) 926 return retval; 927 928 return STATUS_SUCCESS; 929 930 fail: 931 rtsx_read_register(chip, SD_VP_CTL, &val); 932 dev_dbg(rtsx_dev(chip), "SD_VP_CTL: 0x%x\n", val); 933 rtsx_read_register(chip, SD_DCMPS_CTL, &val); 934 dev_dbg(rtsx_dev(chip), "SD_DCMPS_CTL: 0x%x\n", val); 935 936 rtsx_write_register(chip, SD_DCMPS_CTL, DCMPS_CHANGE, 0); 937 rtsx_write_register(chip, SD_VP_CTL, PHASE_CHANGE, 0); 938 mdelay(10); 939 sd_reset_dcm(chip, tune_dir); 940 return STATUS_FAIL; 941 } 942 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
