On 10/29/23 23:24, Greg KH wrote:
On Sun, Oct 29, 2023 at 10:17:21AM -0700, Guenter Roeck wrote:
On Mon, Aug 28, 2023 at 11:39:07AM -0400, Oliver Crumrine wrote:
Remove typedef in enum cvmx_helper_interface_mode_t, and rename all instances
to cvmx_helper_interface_mode
Signed-off-by: Oliver Crumrine <ozlinux@xxxxxxxxxxx>
In linux-next:
Building mips:cavium_octeon_defconfig ... failed
--------------
Error log:
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_get_stats':
drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
204 | struct cvmx_pip_port_status rx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: error: storage size of 'tx_status' isn't known
205 | struct cvmx_pko_port_status tx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c:205:37: warning: unused variable 'tx_status' [-Wunused-variable]
drivers/staging/octeon/ethernet.c:204:37: warning: unused variable 'rx_status' [-Wunused-variable]
204 | struct cvmx_pip_port_status rx_status;
| ^~~~~~~~~
drivers/staging/octeon/ethernet.c: In function 'cvm_oct_probe':
drivers/staging/octeon/ethernet.c:801:22: error: variable 'imode' has initializer but incomplete type
801 | enum cvmx_helper_interface_mode imode =
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/octeon/ethernet.c:801:49: error: storage size of 'imode' isn't known
801 | enum cvmx_helper_interface_mode imode =
| ^~~~~
drivers/staging/octeon/ethernet.c:801:49: warning: unused variable 'imode' [-Wunused-variable]
Bisect points to this patch. Bisect log attached.
As usual, my apologies for the noise if this has already been reported
and/or fixed.
It has not been reported, thanks for it, I'll go revert the offending
commits. And I need to figure out how to build this driver better, I
get no build-failures from anyone for it when stuff like this happens,
odd...
This is kind of chronic. One really has to build mips:cavium_octeon_defconfig
to find Octeon related problems. The all{mod,yes}_defconfig builds don't build
that code.
Guenter
