On Tue, Oct 24, 2023 at 07:44:28AM -0400, Umang Jain wrote: > Drop the log level remnants since the logs are now ported to use > dynamic logging. Drop macros, externs and global variables which > were used in the log level mechanisms along with debugfs log entries. > > Update the drivers/staging/vc04_services/interface/TODO list as well. > > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> > --- > drivers/staging/vc04_services/interface/TODO | 5 - > .../interface/vchiq_arm/vchiq_arm.c | 4 - > .../interface/vchiq_arm/vchiq_arm.h | 3 - > .../interface/vchiq_arm/vchiq_core.c | 87 ++++++--------- > .../interface/vchiq_arm/vchiq_core.h | 11 -- > .../interface/vchiq_arm/vchiq_debugfs.c | 103 ------------------ > 6 files changed, 33 insertions(+), 180 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 6d9d4a800aa7..05eb5140d096 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -23,11 +23,6 @@ should properly handle a module unload. This also includes that all > resources must be freed (kthreads, debugfs entries, ...) and global > variables avoided. > > -* Cleanup logging mechanism > - > -The driver should probably be using the standard kernel logging mechanisms > -such as dev_info, dev_dbg, and friends. > - > * Documentation > > A short top-down description of this driver's architecture (function of I dropped this chunk, and the changlog description of it, as I'm not fully convinced that this portion is done yet. You did the hard work, I think the remaining tiny bit can probably be scripted. thanks, greg k-h
