On Sun, Oct 22, 2023 at 12:24:48PM +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 21, 2023 at 02:48:40PM -0700, Nandha Kumar Singaram wrote: > > Adhere to linux coding style, added parentheses around > > macro argument 'gcam'. > > CHECK: Macro argument 'gcam' may be better as '(gcam)' to > > avoid precedence issues > > > > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@xxxxxxxxx> > > --- > > drivers/staging/greybus/camera.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > index cdbb42cd413b..ae49e37a87e9 100644 > > --- a/drivers/staging/greybus/camera.c > > +++ b/drivers/staging/greybus/camera.c > > @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt) > > > > #define GB_CAMERA_MAX_SETTINGS_SIZE 8192 > > > > -#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format) > > -#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format) > > -#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format) > > +#define gcam_dbg(gcam, format...) dev_dbg(&(gcam)->bundle->dev, format) > > +#define gcam_info(gcam, format...) dev_info(&(gcam)->bundle->dev, format) > > +#define gcam_err(gcam, format...) dev_err(&(gcam)->bundle->dev, format) > > Sorry, but checkpatch is wrong here, this is not a problem at all. Look > at what you changed and think about if the macro argument could actually > be anything other than a pointer. > > thanks, > > greg k-h Thanks, I will check it out. Regards, Nandha Kumar
