On Sun, 22 Oct 2023 09:47:36 +0200 Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> wrote: > On 10/22/23 09:32, Gary Rookard wrote: > > Sorry, but I do both compile and checkpatch, but they seem to be > > failing, don't > > know why yet. I've been using make M=drivers/staging/rtl8192e after > > a complete > > kernel build at make -j3, I'm changing it to Make drivers/staging > > as a matter of recourse. > > gcc version 13.2.1 20230826 (Gentoo 13.2.1_p20230826 p7) > > > > I use checkpatch unflaged on the patch, never a problem before... > > > > On Sun, Oct 22, 2023, at 2:48 AM, Philipp Hortmann wrote: > >> On 10/22/23 00:40, Gary Rookard wrote: > >> > Renamed from Pascal/CamelCase to Snake case the variable > >> > IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps. > >> > Linux > >> kernel > >> > coding style (cleanup) checkpatch Avoid CamelCase. Driver > >> > rtl8192e compiles. Signed-off-by: Gary Rookard > >> > <garyrookard@xxxxxxxxxxxx > >> <mailto:garyrookard@xxxxxxxxxxxx>> --- > >> > drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- > >> > drivers/staging/rtl8192e/rtllib.h | 2 +- > >> > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files > >> > changed, 3 insertions(+), 3 deletions(-) > >> > >> Hi, > >> > >> I assume that now I cannot apply this patch anymore because the > >> previous one is missing. > >> > >> I propose to make a patch series out of the send in patches. > >> Please do a compile test and and use checkpatch. > >> > >> Please include in the version change at which version what changed. > >> > >> Thanks for your support. > >> > >> Bye Philipp > >> > > > > Hi Gary, > > please use: > make -C . M=drivers/staging/rtl8192e > > I am using checkpatch as described here: > https://kernelnewbies.org/FirstKernelPatch > "Git post-commit hooks" > > Please always reply with Bottom Posting. You used top posting which > is not liked by the community and maintainer. > > Bye Philipp Again sorry, it's sorta a GNU habit...mailing lists :( All advice taken, thanks. Regards
