On Sat, Oct 21, 2023 at 10:59:21AM +0200, Jonathan Bergh wrote: > On Sat, Oct 21, 2023 at 10:32:29AM +0200, Greg KH wrote: > > Hi > > > This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > This patch is a *new* patch which replaced a previous *series* of patches > so it was considered a *new* standalone patch, rather than a new version > of the original series. Not really, it's a version 2 as you are doing the same thing. > > - Your patch did many different things all at once, making it difficult > > to review. All Linux kernel patches need to only do one thing at a > > time. If you need to do multiple things (such as clean up all coding > > style issues in a file/driver), do it in a sequence of patches, each > > one doing only one thing. > > This patch only addresses removal of typedefs from the declarations > and fixes up the implmentations that relied on those typedefs. The previous > advice was to not make breaking changes across patches, so this patch > represents code changes which are as atomic as possible in a single patch > without breaking the build. It does not mix formatting / other changes > with the code change. Please fix up one typedef at a time. thanks, greg k-h
