Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 19, 2023 at 11:32:04PM +0200, Andi Shyti wrote:
> Hi Soumya,
> 
> > > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > > > Replace function names in message strings with __func__ to fix
> > > > all checkpatch warnings like:
> > > > 
> > > >     WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > > >              this function's name, in a string
> > > > 
> > > > Signed-off-by: Soumya Negi <soumya.negi97@xxxxxxxxx>
> > > 
> > > you forgot my ack here:
> > > 
> > > Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> 
> > > 
> > > Andi
> > 
> > Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
> > more changes). There will be some new patches, so I'll leave the tags out in 
> > those as you may want to review them first.
> 
> no problem.
> 
> I don't see reviews from Greg in this v2 series. If you are
> referring to the changelog, then you don't need to resend.
> 
> Andi

Hi Andi,

I had sent in v2 after suggestions from Julia and Greg. Got some more
feedback from Greg in the v1 email thread though. Will have to send a v3 due 
to that.

Regards,
Soumya




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux