Re: [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device
From: Stefan Wahren <stefan.wahren@xxxxxxxx>
Date: Thu, 19 Oct 2023 20:18:58 +0200
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
In-reply-to: <20231018055228.825524-1-umang.jain@ideasonboard.com>
References: <20231018055228.825524-1-umang.jain@ideasonboard.com>
Ui-outboundreport: notjunk:1;M01:P0:jyUi8k2PmhQ=;yUpIoZb5eUJwjJ3ofwC3Q6fjQoZ 6abq4652UWJsg/ZxZBfGcV02JpPXgq6GyNx+/aZAgqIxKz5TxS8zySPjr7Bvh0hYVB/KeZmDS 1/x4W4eTPG8CiYLrkPRvBTyS2ZvPG+esCiJuBNJ996f/d4ovLuSmesSf5qIlrMthweqLGVdSs 2ncQSMsbrtefY92d+Gr8felAsO3XKpFuWDjXtCwA2h473VvDbXBd7GyO47hVry2BNauRHKYtz 1THtqXmyng8GOlCMsBCTSqPZdMOn15+1A5U0rjMQQKHLwgbCUAu/3/tQE2n2z0dwmCsYPyWSG wNR+5nHfO9EPviEdvgY9WxDw5oqOB/aaWP1g9ddcEsfy4uJDSZcS9J95i4ZxSoPS/syXNElQC Uy1IOIcrU3UYajgzKcE3PmbIVI8K39EDZtQRsokvdklYp1lT2VOHl2IX/CH5s0BGWBMtUByVw DPfNVj8Ks9Cr44vOQYfx0UGMd2hFCr8VqYv49zZ/kjEhWSiadXytTVwm+GcNHQc0uho5huq1f O12sr2xsQW+usr3RyWNzQabANtPmuCXurDx6tU5mPfbccc0F1yYeOzQucqE56fSmSJKPV9M2y A8Hqsu3PiK0/wiChLuGY2V47X+/dJdrhHtB+00EvuOk5veCNQLnstjdZr2RF4p64gOySxiz6x 3JU4egMETWclSk6uSl+A5hw9GNpqwDKHRHvIVks+BhnQNVRm2XellaoGBQpiz0mhoHTDB6ddt +DhEZEi/dnpSYAGTJqRk5zxEaCrZiQYy2jCulQZYMs/OEJCY66wZ/PaQBPvdDpZ9TiqeyzYH6 P8N/G1/nTtNv9EXoXyHU2IUJp5NhOdxhuMPUmVaZMF/w+e+kT7ejmXyzv3Op4pmrRe5xTwQrb raS21nAPsTwtXaA==
User-agent: Mozilla Thunderbird

Am 18.10.23 um 07:52 schrieb Umang Jain:

As per device_register() documentation, this kfree() on error path will
crash. The call to put_device() is all that is needed here to free the
memory.

Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type")
Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>


Reviewed-by: Stefan Wahren <stefan.wahren@xxxxxxxx>

References:
- [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device
  - From: Umang Jain

Prev by Date: Re: [PATCH] staging: vc04_services: remove empty functions
Next by Date: Re: [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*()
Previous by thread: [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device
Next by thread: [PATCH] tty: gdm724x : Add blank line after variable declarations
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]