On Wed, Oct 18, 2023 at 12:47:01PM -0700, Nandha Kumar Singaram wrote: > Replace the occurrences of (1<<x) by BIT(x) in the files under qlge driver > to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro" > > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@xxxxxxxxx> Thanks, These changes look correct to me. And I do not see any other similar cases left in these files. Reviewed-by: Simon Horman <horms@xxxxxxxxxx> > --- > drivers/staging/qlge/qlge_main.c | 8 ++++---- > drivers/staging/qlge/qlge_mpi.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) ...