Re: [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr and byBBPreEDRSSI

Karolina Stolarek <karolina.stolarek@xxxxxxxxx> · Tue, 17 Oct 2023 11:07:49 +0200

On 17.10.2023 09:19, Gilbert Adikankwu wrote:
On Tue, Oct 17, 2023 at 08:19:49AM +0200, Philipp Hortmann wrote:
On 10/17/23 00:58, Gilbert Adikankwu wrote:
Make the variable names adhere to Linux kernel coding style and mute
checkpatch.pl errors.

A small nit from my side -- "mute" suggests that you suppressed the 
warning/error, but your changes fix them, so why now say "fix 
checkpatch.pl errors"?

Gilbert Adikankwu (4):
    staging: vt6655: Rename variable bUpdateBBVGA
    staging: vt6655: Rename variable byCurrentCh
    staging: vt6655: Rename variable byCurPwr
    staging: vt6655: Rename variable byBBPreEDRSSI

   drivers/staging/vt6655/baseband.c    |  2 +-
   drivers/staging/vt6655/channel.c     | 18 +++++++++---------
   drivers/staging/vt6655/device.h      |  8 ++++----
   drivers/staging/vt6655/device_main.c |  8 ++++----
   drivers/staging/vt6655/dpc.c         |  2 +-
   drivers/staging/vt6655/rf.c          |  4 ++--
   6 files changed, 21 insertions(+), 21 deletions(-)

Hi,

-       if (priv->byCurrentCh == ch->hw_value)
+       if (priv->current_ch == ch->hw_value)^M
                 return ret;

ERROR: DOS line endings

What does the "^M" at the end of the new line?
Did you run checkpatch on your patches?

Thanks

Bye

Philipp

Hello,

I do not know what this error means. If anything, I'm surprised there is
an error. checkpatch is hooked to my git commit and all the patches
built cleanly on my machine. I will resend now.

I'm not seeing that error when the patch is applied. You could 
double-check the patch files before sending by calling checkpatch.pl on 
them directly.

This could be also because of how some email clients change the endings 
on download, like Thunderbird, and the patch itself might be fine.

All the best,
Karolina

Thanks
Gilbert