Hi Greg, On Sun, Oct 15, 2023 at 02:50:44PM +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 14, 2023 at 11:07:16PM -0700, Soumya Negi wrote: > > On Sun, Oct 15, 2023 at 07:37:30AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 13, 2023 at 01:26:35AM -0700, Soumya Negi wrote: > > > > Fix WARNING: Missing a blank line after declarations > > > > Issue found by checkpatch.pl > > > > > > > > Signed-off-by: Soumya Negi <soumya.negi97@xxxxxxxxx> > > > > --- > > > > drivers/staging/gdm724x/gdm_tty.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Why do you have "tty:" as the prefix for a staging driver? Shouldn't it > > > be "staging: gdm724x: ...."? > > > > Hi Greg, > > > > Thats what I thought too. But when I looked at the git history for > > gdm_tty.c the last few commits had "tty:". So I went with that. > > That is because those commits were tty-wide, and they changed things in > multiple drivers all at once, not just for the one file. > > > Should I change it to "staging:"? > > Please do. I'm sending this patch in a new thread since the other patch in the patchset(had 2 patches) was reviewed as unneeded. Regards, Soumya
