On Fri, Oct 13, 2023 at 01:21:21PM +0300, Calvince Otieno wrote: > Checkpatch suggests the use of strscpy() instead of strncpy(). > The advantages are that it always adds a NUL terminator and it prevents > a read overflow if the src string is not properly terminated. One > potential disadvantage is that it doesn't zero pad the string like > strncpy() does. > > In this code, strscpy() and strncpy() are equivalent and it does not > affect runtime behavior. The string is zeroed on the line before > using memset(). The resulting string was always NUL terminated and > PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL > terminated. > > However, even though using strscpy() does not fix any bugs, it's > still nicer and makes checkpatch happy. > > Signed-off-by: Calvince Otieno <calvncce@xxxxxxxxx> > --- > Patch version v5: > Removed v1 patch details from the revsion history This patch doesn't apply correctly. It has been white space damaged for some reason. Tabs replaced with spaces. Read Documentation/process/email-clients.rst. Hopefully the first paragraph convinces you to just use git to send patchs and you can skip the rest of the document. I try to catch these sorts of mistakes earlier instead of making you send a v6 but I thought the issue was the v1. Sorry about that. The good news is that now you can delete the extra space character Julia mentioned. regards, dan carpenter
