Warning found by checkpatch.pl script. Fixes warning replacing printk to pr_crit and fixes conding style. Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@xxxxxxxxx> --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 21 +++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 490431484524..e178a6881e0c 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -48,7 +48,6 @@ static void sd_sync_int_hdl(struct sdio_func *func) { struct dvobj_priv *psdpriv; - psdpriv = sdio_get_drvdata(func); if (!psdpriv->if1) @@ -73,7 +72,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj) err = sdio_claim_irq(func, &sd_sync_int_hdl); if (err) { dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++; - printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err); + pr_crit("%s: sdio_claim_irq FAIL(%d)!\n", __func__, err); } else { dvobj->drv_dbg.dbg_sdio_alloc_irq_cnt++; dvobj->irq_alloc = 1; @@ -81,7 +80,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj) sdio_release_host(func); - return err?_FAIL:_SUCCESS; + return err ? _FAIL : _SUCCESS; } static void sdio_free_irq(struct dvobj_priv *dvobj) @@ -102,8 +101,9 @@ static void sdio_free_irq(struct dvobj_priv *dvobj) netdev_err(dvobj->if1->pnetdev, "%s: sdio_release_irq FAIL(%d)!\n", __func__, err); - } else + } else { dvobj->drv_dbg.dbg_sdio_free_irq_cnt++; + } sdio_release_host(func); } dvobj->irq_alloc = 0; @@ -169,6 +169,7 @@ static void sdio_deinit(struct dvobj_priv *dvobj) sdio_release_host(func); } } + static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { int status = _FAIL; @@ -239,8 +240,8 @@ static void sd_intf_stop(struct adapter *padapter) rtw_hal_disable_interrupt(padapter); } - -static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct sdio_device_id *pdid) +static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, + const struct sdio_device_id *pdid) { int status = _FAIL; struct net_device *pnetdev; @@ -273,7 +274,6 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct /* 4 3.1 set hardware operation functions */ rtw_set_hal_ops(padapter); - /* 3 5. initialize Chip version */ padapter->intf_start = &sd_intf_start; padapter->intf_stop = &sd_intf_stop; @@ -290,7 +290,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct rtw_hal_chip_configure(padapter); - hal_btcoex_Initialize((void *) padapter); + hal_btcoex_Initialize((void *)padapter); /* 3 6. read efuse/eeprom data */ rtw_hal_read_chip_info(padapter); @@ -359,9 +359,7 @@ static void rtw_sdio_if1_deinit(struct adapter *if1) * notes: drv_init() is called when the bus driver has located a card for us to support. * We accept the new device by returning 0. */ -static int rtw_drv_init( - struct sdio_func *func, - const struct sdio_device_id *id) +static int rtw_drv_init(struct sdio_func *func, const struct sdio_device_id *id) { int status = _FAIL; struct adapter *if1 = NULL; @@ -501,6 +499,5 @@ static void __exit rtw_drv_halt(void) rtw_ndev_notifier_unregister(); } - module_init(rtw_drv_entry); module_exit(rtw_drv_halt); -- 2.39.2