This series is working towards moving the ad2s1210 resolver driver out of staging (after 13 years!). It involves a bunch of fixes and improvements to make proper device tree bindings and use standard IIO sysfs attributes. This series has been tested on actual hardware using a EVAL-AD2S1210 evaluation board. (Note: not all device tree features have been implemented in the driver since the eval board doesn't support them out of the box. We plan to add them later if needed.) --- v5 changes: * Dropped applied patches: * "staging: iio: resolver: ad2s1210: do not use fault register for dummy read" * "staging: iio: resolver: ad2s1210: implement hysteresis as channel attr" * "staging: iio: resolver: ad2s1210: convert fexcit to channel attribute" * "staging: iio: resolver: ad2s1210: convert resolution to devicetree property" * "staging: iio: resolver: ad2s1210: add phase lock range support" * "staging: iio: resolver: ad2s1210: add triggered buffer support" * "staging: iio: resolver: ad2s1210: convert LOT threshold attrs to event attrs" * "staging: iio: resolver: ad2s1210: convert LOS threshold to event attr" * "staging: iio: resolver: ad2s1210: convert DOS overrange threshold to event attr" * "staging: iio: resolver: ad2s1210: convert DOS mismatch threshold to event attr" * "staging: iio: resolver: ad2s1210: rename DOS reset min/max attrs" * "iio: event: add optional event label support" * "staging: iio: resolver: ad2s1210: implement fault events" * "staging: iio: resolver: ad2s1210: add register/fault support summary" * "staging: iio: resolver: ad2s1210: add label attribute support" * "staging: iio: resolver: ad2s1210: remove fault attribute" * Added new patches: * "staging: iio: resolver: ad2s1210: refactor sample toggle" * "staging: iio: resolver: ad2s1210: clear faults after soft reset" * "iio: resolver: ad2s1210: move out of staging" Link to v4: https://lore.kernel.org/r/20231005-ad2s1210-mainline-v4-0-ec00746840fc@xxxxxxxxxxxx v4 changes: * Dropped applied patches: * "dt-bindings: iio: resolver: add devicetree bindings for ad2s1210" * "staging: iio: resolver: ad2s1210: read excitation frequency from control register" * "staging: iio: resolver: ad2s1210: refactor setting excitation frequency" * "staging: iio: resolver: ad2s1210: rework gpios" * "staging: iio: resolver: ad2s1210: remove config attribute" * "staging: iio: resolver: ad2s1210: add debugfs reg access" * "staging: iio: resolver: ad2s1210: use regmap for config registers" * "staging: iio: resolver: ad2s1210: use devicetree to get CLKIN rate" * "staging: iio: resolver: ad2s1210: implement IIO_CHAN_INFO_SCALE" * "staging: iio: resolver: ad2s1210: always use 16-bit value for raw read" * "staging: iio: resolver: ad2s1210: sort imports" * "staging: iio: resolver: ad2s1210: remove spi_set_drvdata()" * "staging: iio: resolver: ad2s1210: check return of ad2s1210_initial()" * "staging: iio: resolver: ad2s1210: remove call to spi_setup()" * "staging: iio: resolver: ad2s1210: fix use before initialization" * Added new patches: * "staging: iio: resolver: ad2s1210: do not use fault register for dummy read" * "iio: event: add optional event label support" * "staging: iio: resolver: ad2s1210: add register/fault support summary" * "staging: iio: resolver: ad2s1210: remove fault attribute" * "staging: iio: resolver: ad2s1210: simplify code with guard(mutex)" * Fixed DT property name in commit description of "staging: iio: resolver: ad2s1210: convert resolution to devicetree property" * Fixed compile error in "staging: iio: resolver: ad2s1210: implement fault events". * Fixed angl0 hysteresis raw values when assigned-resolution-bits != 16. * Fixed missing word in "staging: iio: resolver: ad2s1210: convert DOS overrange threshold to event attr" commit description. * Fixed missing static qualifier on event attribute definitions. * Dropped used of X/Y modifiers on sine/cosine channels. * Changed type/direction on some events. * Added event *_label attributes. Link to v3: https://lore.kernel.org/r/20230929-ad2s1210-mainline-v3-0-fa4364281745@xxxxxxxxxxxx v3 changes: * Dropped applied patches: * "staging: iio: resolver: ad2s1210: fix ad2s1210_show_fault" * "staging: iio: resolver: ad2s1210: fix not restoring sample gpio in channel read" * Dropped "staging: iio: Documentation: document IIO resolver AD2S1210 sysfs attributes". We will attempt to use existing ABI for faults/ thresholds in a future series. * Added description of A0/A1 lines in DT bindings. * Added power supply regulators to DT bindings. * Moved sorting imports to separate patch. * Renamed fclkin to clkin_hz. * Added __be16 sample field to state struct for reading raw samples. * Split out new function ad2s1210_single_conversion() from ad2s1210_read_raw(). * Split out new ad2s1210_get_hysteresis() and ad2s1210_set_hysteresis() functions. * Fixed multi-line comment style. * Added notes about soft reset not resetting config registers. * Made use of FIELD_PREP() macro. * Added more explanation to regmap commit message. * Removed datasheet names from channel specs. * Replaced "staging: iio: resolver: ad2s1210: rename fexcit attribute" with "staging: iio: resolver: ad2s1210: convert fexcit to channel attribute". * Replaced "staging: iio: resolver: ad2s1210: add phase_lock_range attributes" with "staging: iio: resolver: ad2s1210: add phase lock range support" * Added additional patches to convert custom device attributes to event attributes. * Added patch for to add label attributes. Link to v2: https://lore.kernel.org/r/20230921144400.62380-1-dlechner@xxxxxxxxxxxx v2 changes: * Address initial device tree patch feedback * Drop "iio: sysfs: add IIO_DEVICE_ATTR_NAMED_RW macro" (related cleanups also dropped for now, will address in a future series if needed) * Apply improvements as a series of patches to the staging driver. It is not quite ready for the move out of staging patch yet. --- David Lechner (4): staging: iio: resolver: ad2s1210: refactor sample toggle staging: iio: resolver: ad2s1210: clear faults after soft reset staging: iio: resolver: ad2s1210: simplify code with guard(mutex) iio: resolver: ad2s1210: move out of staging .../ABI/testing}/sysfs-bus-iio-resolver-ad2s1210 | 0 drivers/iio/resolver/Kconfig | 13 ++ drivers/iio/resolver/Makefile | 1 + drivers/{staging => }/iio/resolver/ad2s1210.c | 208 ++++++++++----------- drivers/staging/iio/Kconfig | 1 - drivers/staging/iio/Makefile | 1 - drivers/staging/iio/resolver/Kconfig | 19 -- drivers/staging/iio/resolver/Makefile | 6 - 8 files changed, 109 insertions(+), 140 deletions(-) --- base-commit: 57fd97ead0e87ca528736f1945a3ba3096de2f3e change-id: 20230925-ad2s1210-mainline-2791ef75e386 Best regards, -- David Lechner <dlechner@xxxxxxxxxxxx>
