On Fri, Sep 29, 2023 at 12:23:07PM -0500, David Lechner wrote: > From: David Lechner <david@xxxxxxxxxxxxxx> > > From: David Lechner <dlechner@xxxxxxxxxxxx> > > This fixes a use before initialization in ad2s1210_probe(). The > ad2s1210_setup_gpios() function uses st->sdev but it was being called > before this field was initialized. > > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx> > --- > Fixes: b19e9ad5e2cb ("staging:iio:resolver:ad2s1210 general driver cleanup.") This would crash the driver right away, on probe. It's amazing no one filed a bug report even though the bug is 12 years old. regards, dan carpenter