Re: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
Subject: Re: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 14 Sep 2023 09:38:01 +0300
Cc: linux-staging@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Stefan Wahren <stefan.wahren@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Adrien Thierry <athierry@xxxxxxxxxx>, Dan Carpenter <error27@xxxxxxxxx>, Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>, Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>, Phil Elwell <phil@xxxxxxxxxxxxxxx>
In-reply-to: <20230913185528.770634-4-umang.jain@ideasonboard.com>
References: <20230913185528.770634-1-umang.jain@ideasonboard.com> <20230913185528.770634-4-umang.jain@ideasonboard.com>

Please rename vchiq_log_info() to vchiq_log_dbg() or something.  When I
see "info", I think it's a KERN_INFO level.  This is all debug stuff and
it's done correctly but the name is misleading so it looks wrong.

regards,
dan carpenter

References:
- [RFC PATCH v2 0/4] staging: vc04: Drop custom logging
  - From: Umang Jain
- [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug
  - From: Umang Jain

Prev by Date: Re: [RFC PATCH v2 0/4] staging: vc04: Drop custom logging
Next by Date: Re: [PATCH v11 5/5] staging: vc04_services: vchiq_arm: Remove vchiq_register_child()
Previous by thread: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug
Next by thread: [RFC PATCH v2 4/4] staging: vc04: Convert vchiq_log_trace() to use dynamic debug
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]